Core: Simplify first-iteration check in Partitioning.commonActiveFieldIds - #17798
Open
uros-b wants to merge 1 commit into
Open
Core: Simplify first-iteration check in Partitioning.commonActiveFieldIds#17798uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
…dIds Replace the manual specIndex counter, used only to detect the first spec, with a boolean flag.
uros-b
commented
Aug 24, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Please review @aokolnychyi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Partitioning.commonActiveFieldIds, the loop uses anint specIndexcounter solely to detect the first spec (the first spec seeds the set withaddAll, the rest intersect withretainAll). Replaces it with aboolean firstflag, which expresses the intent directly and drops the unused running count. Behavior-preserving; no functional change.