Flink: Exclude Vintage and clean up test deps - #17770
Open
subhramit wants to merge 5 commits into
Open
Conversation
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
3 tasks
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
uros-b
reviewed
Aug 23, 2026
| junit-jupiter = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junit" } | ||
| junit-jupiter-engine = { module = "org.junit.jupiter:junit-jupiter-engine", version.ref = "junit" } | ||
| junit-pioneer = { module = "org.junit-pioneer:junit-pioneer", version.ref = "junit-pioneer" } | ||
| junit-v4 = { module = "junit:junit", version.ref = "junit4" } |
Member
There was a problem hiding this comment.
junit-v4 is inserted between junit-pioneer (line 213) and junit-platform-launcher (line 214), but the junit-* library block is strictly alphabetically ordered (junit-jupiter → junit-jupiter-engine → junit-pioneer → junit-platform-launcher → junit-suite-api → junit-suite-engine). Since v > s, junit-v4 should be placed after junit-suite-engine. A one-line reorder in the TOML is all that is needed.
Signed-off-by: subhramit <subhramit.bb@live.in>
Author
|
Also cc'ing @mxm @nastra @huaxingao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #12937.
Exclude
junitandorg.junit.vintagefrom theconnector.test.utilsandtest.utilstest dependencies in all three Flink modules (v1.20,v2.0,v2.1), and remove the now-redundant explicitflink-test-utils-junitdependency and itslibs.versions.tomlaliases.Keep
junit:junitas an explicit runtime-only dependency for Flink tests and integration tests in those modules as a temporary workaround for Flink's own transitive test infrastructure.Full removal of JUnit 4 from the Flink test runtime remains blocked upstream by FLINK-25325.
Although the Iceberg Flink tests in this branch already use JUnit 5 extensions (for example,
TestIcebergSourceFailoverusesMiniClusterExtension, notMiniClusterWithClientResource), Flink's transitiveflink-test-utils-junitimplementation still requires JUnit 4 classes at runtime.Testing
Verified via repo search that no Iceberg Flink test class under
flink/referencesMiniClusterWithClientResource,org.junit.rules,@Rule, orExternalResource. Also ran:./gradlew :iceberg-flink:iceberg-flink-2.0:dependencies --configuration testRuntimeClasspath | grep -i junit(see output below in Details)
to confirm
junit-vintage-engineandorg.junit.vintageno longer resolve.junit:junit:4.13.2still resolves intentionally as an explicit runtime-only workaround.Details
Also ran some focused tests: