Core: Precompute sorted entries in ShreddedObject SerializationState#17114
Open
nssalian wants to merge 1 commit into
Open
Core: Precompute sorted entries in ShreddedObject SerializationState#17114nssalian wants to merge 1 commit into
nssalian wants to merge 1 commit into
Conversation
518e15e to
a5f6fab
Compare
wombatu-kun
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Precomputes a sorted
Entry[]once in theSerializationStateconstructor.writeTobecomes an index loop over the array.Per-writeTo, this removes:
SortedMerge.of(...)+ twostream().sorted()iteratorsshreddedFields.get+unshreddedFields.get)Maps.newHashMap(shredded)defensive copyThe
Maps.newHashMap(shredded)copy was there to stop the old code from accidentallymodifying the caller's map (#15087). The refactor never modifies the caller's map, so the copy is no longer needed.
Tests
Three new tests in
TestShreddedObject:testPutAfterRemoveIsSerialized-remove(x)thenput(x, v)semanticstestEmptyObject- zero-field statetestRepeatedWriteToProducesSameBytes- cached-state reuse across writes