GCP: Add support for configurable KMS endpoint in GcpKeyManagementClient#17111
Open
ebyhr wants to merge 2 commits into
Open
GCP: Add support for configurable KMS endpoint in GcpKeyManagementClient#17111ebyhr wants to merge 2 commits into
ebyhr wants to merge 2 commits into
Conversation
singhpk234
reviewed
Jul 6, 2026
singhpk234
left a comment
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
+1 to having same key as kms.endpoint this will help maintain consistency !
is it possible to add test for it ? changes / motivation LGTM
Member
Author
|
Thanks for your review! I've added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trino is replacing real SaaS-based tests with Floci. This change allows for configurable KMS endpoints, which benefits the project.
The endpoints in AwsProperties and AzureProperties are already configurable.
iceberg/aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
Line 218 in 05c5d77
iceberg/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java
Line 51 in 05c5d77