Core: Reject reserved properties in snapshot summary set()#17107
Open
sachinnn99 wants to merge 1 commit into
Open
Core: Reject reserved properties in snapshot summary set()#17107sachinnn99 wants to merge 1 commit into
sachinnn99 wants to merge 1 commit into
Conversation
User-supplied properties via SnapshotUpdate.set() could silently occupy reserved metric keys when the metric was not computed for the commit, corrupting the snapshot summary. Add reserved-key validation to SnapshotSummary.Builder.set() following the existing TableProperties.RESERVED_PROPERTIES pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnapshotUpdate.set(String, String)lets callers supply arbitrary key/value pairs for the snapshot summary. InsideSnapshotSummary.Builder.build(), custom properties are copied first and computed metrics overwrite them, which protects a metric key only when the metric is actually computed for the commit. A user-supplied value under a reserved metric key that is not computed (e.g.set("added-delete-files", "5")on a commit that adds no delete files) survives into the final summary unchallenged.This adds reserved-key validation to
SnapshotSummary.Builder.set()so that reserved metric keys and thepartitions.prefix are rejected with anIllegalArgumentException. Internal callers (SnapshotProducer,BaseRewriteManifests) that legitimately write reserved keys use a new package-privatesetInternal()bypass. Non-metric operation properties likewap.idremain settable through the public API.Fixes #17009