REST-Fixture: Ensure strict mode on jdbc catalog for rest fixture#13599
REST-Fixture: Ensure strict mode on jdbc catalog for rest fixture#13599stevenzwu merged 2 commits intoapache:mainfrom
Conversation
Co-authored-by: Fokko Driesprong <fokko@apache.org>
There was a problem hiding this comment.
LGTM i verified this locally when testing apache/iceberg-python#2090
With this change, tables can no longer be created without first creating its namespace in the iceberg-rest-fixture REST server. This aligns with the general expectation when creating a table in a catalog.
|
With this change, tables can no longer be created without first creating its namespace in the Before we merge this, i want to make sure we're all align on the deployment for Once we merge this PR, it'll be build as the |
|
It makes sense to align the text fixture to the REST spec where |
When adding common catalog integration tests in pyiceberg, we noticed that the rest catalog test, which tests against the rest fixture was failing to throw a
NoSuchNamespaceErrorwhen attempting to create a table in a namespace that does not exist. @kevinjqliu spotted the issue and we are able to resolve downstream by settingCATALOG_JDBC_STRICT__MODE=truein thedocker-compose-integration.yml, but I think it makes sense to set that variable here to ensure we have consistent behavior wherever this fixture is used.Tests are now passing downstream with the environment variable set, and the rest catalog is behaving in line with other catalog implementations in the integration tests, which I believe is proof enough that it is safe to make this change here.