Skip to content

chore(storage-opendal): address review nits from #3179 - #3657

Open
YuangGao wants to merge 1 commit into
apache:mainfrom
YuangGao:chore/s3-part-size-followups
Open

YuangGao wants to merge 1 commit into
apache:mainfrom
YuangGao:chore/s3-part-size-followups

Conversation

@YuangGao

@YuangGao YuangGao commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

What changes are included in this PR?

Addresses the review nits on #3179:

  • Note why the part-size cast can't fail for parsed values.
  • Document why default_multipart_part_size is a named serde default.
  • upload_part_count returns None for a bare-MD5 ETag, so the single-request test asserts it went out as one request.

Are these changes tested?

  • The S3 tests pass against the RustFS fixture.

AI Disclosure

  • AI-assisted implementation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant