ci: pull MinIO images from Quay - #3202
Merged
Merged
Conversation
Docker Hub no longer serves the MinIO server and client repositories, preventing integration test containers from starting. Use the corresponding Quay images with the existing release tags. Generated-by: Codex
smaheshwar-pltr
marked this pull request as ready for review
September 11, 2026 22:50
CTTY
enabled auto-merge
September 11, 2026 23:19
This was referenced Sep 11, 2026
Collaborator
|
I think we need a repo admin/PMC to bypass merge this to fix the merge queue. |
kevinjqliu
approved these changes
Sep 11, 2026
Contributor
hmm whats going on with the merge queue? let me check |
nssalian
approved these changes
Sep 11, 2026
Contributor
Contributor
|
nice that went through. thanks for the PR! |
kevinjqliu
added a commit
that referenced
this pull request
Sep 14, 2026
Docker Hub no longer serves the MinIO server and client repositories, preventing integration test containers from starting. Use the corresponding Quay images with the existing release tags. Generated-by: Codex (cherry picked from commit 9e1670d) Co-authored-by: Sreesh Maheshwar <maheshwarsreesh@gmail.com> Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
dannycjones
added a commit
to dannycjones/iceberg-rust
that referenced
this pull request
Sep 14, 2026
CTTY
pushed a commit
that referenced
this pull request
Sep 14, 2026
* chore: Update changelog for 0.11.0 RC2 * chore: Add #3202 MinIO Quay backport to changelog
patrickwwbutler
pushed a commit
to MaterializeInc/iceberg-rust
that referenced
this pull request
Sep 16, 2026
Docker Hub no longer serves the MinIO server and client repositories, preventing integration test containers from starting. Use the corresponding Quay images with the existing release tags. Generated-by: Codex Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
ghbvf
pushed a commit
to shengming0817/rss
that referenced
this pull request
Sep 19, 2026
## Summary 修复 develop CI 的三个根因：升级 Rustls 安全补丁、恢复 MinIO 归档测试镜像来源，并让覆盖率汇总使用原构建的 Cargo home。 ## Why / 背景 [CI 35138645968](https://github.com/shengming0817/rss/actions/runs/35138645968) 中，rustls 0.23.41 命中 RUSTSEC-2026-0285；Docker Hub 的 MinIO 镜像无法拉取；coverage job 与构建 job 的 CARGO_HOME 不同，使 94 个第三方源码文件进入覆盖率分母。报告原值为 66.56%，同一 LCOV 仅统计仓内源码为 88.89%。 - workspace 声明提高 Rustls 最低版本至 0.23.45，锁文件同步更新 Rustls 及其要求的 rustls-webpki。 - MinIO 改用 Quay，保持 RELEASE.2025-02-28T09-55-16Z 和现有 TLS / Object Lock 测试语义。 - build manifest 记录实际编译使用的绝对 cargo_home，报告子进程消费该字段，沿用 cargo-llvm-cov 的 registry/git 默认排除规则。构建与汇总路径无需相同；缺失或非法字段拒绝消费。 ## Refs - [Rustls 官方安全公告](GHSA-2mjx-qc3c-rqvc) - ref: cargo-llvm-cov [v0.8.7 src/report.rs::ignore_filename_regex](https://github.com/taiki-e/cargo-llvm-cov/blob/v0.8.7/src/report.rs#L938) - ref: cargo [crates/home/src/env.rs::cargo_home_with_cwd_env](https://github.com/rust-lang/cargo/blob/master/crates/home/src/env.rs) - ref: apache/iceberg-rust [PR #3202](apache/iceberg-rust#3202) ## Risk / 兼容性 公共 API 和数据库 schema 不变；内部 build manifest 增加必需字段，旧 archive 须重新生成，不保留兼容回退。测试结果仍绑定 manifest 摘要，缺组、损坏和失败继续阻断，80% 行覆盖率门槛不变。 ## Test plan - [x] 回归先失败再通过：Cargo home 默认 / 空值 / 相对 / 绝对路径、不同消费环境、manifest 缺失与非法字段、manifest 摘要绑定。 - [x] CI Python 自测：119 tests，OK（1 个既有条件跳过）。 - [x] cargo deny check -D unused-wrapper：advisories / bans / licenses / sources 全部通过。 - [x] cargo audit：退出 0；仍报告 event-listener 5.4.1 与 lru 0.16.4 两条既有允许告警。 - [x] Quay 固定版本镜像实际拉取成功；archive-integration 两个用例全部通过。 - [x] 真实 cargo-llvm-cov 0.8.7 消费证明（macOS）：显式插桩外部依赖以构造含第三方路径的原对象，构建一次；旧报告方式为 6/36（16.67%）、退出 1；修复后两个不同消费 Cargo home 均为 2/2（100%）、退出 0，原 archive 摘要保持不变。 - [x] 修改涉及的 testkit 格式检查通过。全仓格式检查另有既存 projection-postgres/src/transaction.rs:23 排版差异，本 PR 未修改该文件。 - [ ] 最终 HEAD：make ci CI_BASE=origin/develop CI_FULL=1（内置 review 与交接后执行，结果追加到本 PR）。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Docker Hub is no longer serving
minio/minio(https://hub.docker.com/r/minio/minio) orminio/mc(https://hub.docker.com/r/minio/mc), stopping the integration test containers from starting onmainand affecting open PRs.This PR switches to the corresponding Quay images, as the related PRs above do - those other projects are encountering the same issue as us.
We should track moving away from MinIO as a follow-up, like PyIceberg did - but that's a larger discussion; this fix is temporary to unblock CI, PRs, etc.
AI Disclosure: Assisted by Codex (GPT-6).