Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4189
Rationale for this change
last_updated_msto its own timestamp. If another commit lands before the transaction commits, the new metadata ends up older than its latestmetadata-logentry, and Java rejects it once the gap exceeds a minute.update_table_metadatanow bumpslast_updated_msto the current time whenever it doesn't come after the base metadata's, not only when they're equal.Are these changes tested?
test_init.py— a snapshot older than the base metadata no longer setslast_updated_msbefore the latest metadata-log entry.test_update_metadata_with_multiple_updatesused a snapshot timestamp older than its base metadata, so it now uses a later one.Are there any user-facing changes?