Repository navigation
docs: Fix GCS default bucket location key and document s3.ssl.ca-cert - #4179
Open
sarthakuwar wants to merge 1 commit into
Open
sarthakuwar wants to merge 1 commit into
sarthakuwar wants to merge 1 commit into
Conversation
ebyhr
approved these changes
Oct 29, 2026
rambleraptor
approved these changes
Oct 31, 2026
rambleraptor
left a comment
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
Easy peasy. Thanks for the fix!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
mkdocs/docs/configuration.mddocumentsgcs.default-location, but the code reads a different key:Both
PyArrowFileIO(pyiceberg/io/pyarrow.py, passed asdefault_bucket_location) andFsspecFileIO(pyiceberg/io/fsspec.py, passed asdefault_location) look upgcs.default-bucket-location. Anyone who sets the documented key gets no error, and the setting is silently ignored.While there, I added the missing
s3.ssl.ca-certrow to the S3 table. It is read inPyArrowFileIO._set_tls_ca_file_pathand needs pyarrow 21.0.0 or later (the code raisesImportErrorotherwise). It is not used byFsspecFileIO.Are these changes tested?
Docs only. I checked both keys against the constants in
pyiceberg/io/__init__.pyand where they are read, and ranmarkdownlint(v0.45.0, the version in.pre-commit-config.yaml) andcodespellon the file. Both pass.Are there any user-facing changes?
Docs only. No code changes.