Skip to content

perf(types): avoid double iteration in transform_dict_value_to_str #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 1 commit into from
Sep 18, 2026
+5 −3
Merged

perf(types): avoid double iteration in transform_dict_value_to_str #3988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pyiceberg/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,14 @@
GEOGRAPHY_REGEX = re.compile(r"geography(?:\(\s*['\"]([^'\"]+)['\"](?:\s*,\s*['\"]([^'\"]+)['\"])?\s*\))?$")


def transform_dict_value_to_str(dict: dict[str, Any]) -> dict[str, str]:
def transform_dict_value_to_str(d: dict[str, Any]) -> dict[str, str]:
"""Transform all values in the dictionary to string. Raise an error if any value is None."""
for key, value in dict.items():
result = {}
for key, value in d.items():
if value is None:
raise ValueError(f"None type is not a supported value in properties: {key}")
return {k: str(v).lower() if isinstance(v, bool) else str(v) for k, v in dict.items()}
result[key] = str(value).lower() if isinstance(value, bool) else str(value)
return result


def _parse_decimal_type(decimal: Any) -> tuple[int, int]:
Expand Down
Loading