Skip to content

Enhance URI scheme validation for Windows paths #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlgoDeveloper400 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Enhance URI scheme validation for Windows paths #3161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
115bc90
Enhance URI scheme validation for Windows paths
AlgoDeveloper400 Mar 17, 2026
7b1365b
Remove unnecessary blank line in pyarrow.py
AlgoDeveloper400 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyiceberg/io/pyarrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,8 @@ def parse_location(location: str, properties: Properties = EMPTY_DICT) -> tuple[
"""
uri = urlparse(location)

if not uri.scheme:
if not uri.scheme or (len(uri.scheme) == 1 and uri.scheme.isalpha()):
# len == 1 and alpha catches Windows drive letters like C:\ D:\
default_scheme = properties.get("DEFAULT_SCHEME", "file")
default_netloc = properties.get("DEFAULT_NETLOC", "")
return default_scheme, default_netloc, os.path.abspath(location)
Copy link
Copy Markdown
Member

@geruh geruh Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few other places use the urlparse and will be affected like fs spec and schema resolution.

iceberg-python/pyiceberg/io/__init__.py

Lines 337 to 346 in 3a993e8

def _infer_file_io_from_scheme(path: str, properties: Properties) -> FileIO | None:
parsed_url = urlparse(path)
if parsed_url.scheme:
if file_ios := SCHEMA_TO_FILE_IO.get(parsed_url.scheme):
for file_io_path in file_ios:
if file_io := _import_file_io(file_io_path, properties):
return file_io
else:
warnings.warn(f"No preferred file implementation for scheme: {parsed_url.scheme}", stacklevel=2)
return None

Maybe we could create a helper in the init class that all modules could use.

Expand Down
Loading