Add V3 manifest/manifest-list writing and row-lineage snapshot commits#3070
Open
SaymV wants to merge 2 commits intoapache:mainfrom
Open
Add V3 manifest/manifest-list writing and row-lineage snapshot commits#3070SaymV wants to merge 2 commits intoapache:mainfrom
SaymV wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Linking this PR to the long-running V3 writer tracker: #1551 ("Support writing V3 tables"). This change is the core manifest/manifest-list + metadata/snapshot writer path that unblocks practical V3 table writes (including geospatial-driven V3 usage), while still deferring broader full V3 parity work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManifestWriterV3andManifestListWriterV3, including v3 manifest-listfirst_row_idassignmentfirst_row_idandadded_rowsfrom manifest-list row-id assignmentnext_row_id=0for new/upgraded v3 tablesImplementation notes
DEFAULT_READ_VERSIONin manifest handling is now3so v3 fields (includingManifestFile.first_row_id) are preserved when reading/re-writing manifests.first_row_id, and advance byexisting_rows_count + added_rows_count.Follow-up scope (tracked by #1551)
#1551.Validation
./.venv/bin/python -m pytest -q tests/table/test_metadata.py tests/table/test_init.py tests/utils/test_manifest.pyuv run python -m pytest -q tests/integration/test_reads.py -k upgrade_table_versionuv run python -m pytest -q tests/integration/test_writes/test_writes.py -k "test_nanosecond_support_on_catalog or test_v3_write_and_read_row_lineage"Related: #1551