fix: include uv.lock in release tarball#2987
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Jan 30, 2026
Merged
Conversation
kevinjqliu
approved these changes
Jan 30, 2026
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM
this should be included. we added poetry.lock in #2405 for the same reason.
i guess this was missed during the uv migration, #2601 (review)
i dont see uv.lock in the "new" section
Contributor
|
I think this is reasonable, but would there be a way to include a ASF 2.0 license? Otherwise we might need to add an exclusion to the license checker. |
Contributor
|
we already have uv.lock in the rat exclude iceberg-python/dev/.rat-excludes Line 6 in 78615d2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Include uv.lock in sdist so dependency resolution matches the release branch.
Are these changes tested?
Yes
Are there any user-facing changes?
No