add more tests for update_column changing list/map optionality#2950
Merged
Fokko merged 2 commits intoapache:mainfrom Jan 25, 2026
Merged
add more tests for update_column changing list/map optionality#2950Fokko merged 2 commits intoapache:mainfrom
update_column changing list/map optionality#2950Fokko merged 2 commits intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the update_column functionality that allows changing the required property for list elements and map values, which was fixed in PR #2798.
Changes:
- Refactored two existing tests to use inline type construction and constructor parameter for
allow_incompatible_changes - Added 7 new test functions covering edge cases: safe direction changes (required→optional), unsafe changes without flag, map key update restrictions, combined updates, and nested structure updates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow up to #2798
More test coverages
Are these changes tested?
Are there any user-facing changes?