Check storage-credentials before config in table response#2600
Open
coca-alex wants to merge 9 commits intoapache:mainfrom
Open
Check storage-credentials before config in table response#2600coca-alex wants to merge 9 commits intoapache:mainfrom
coca-alex wants to merge 9 commits intoapache:mainfrom
Conversation
Author
|
@Fokko Could you please review the changes that I’ve made? I fixed errors in ci steps. |
kevinjqliu
reviewed
Jan 16, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks @coca-alex for the PR! I did not see it until now. Left a few comments.
Overall, it looks great!
heres the logic for prefix matching in the java impl
https://github.com/apache/iceberg/blob/38cc88136684a57b61be4ae0d2c1886eff742a28/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java#L379-L428
| table_response.storage_credentials, | ||
| table_response.config, | ||
| table_response.metadata_location, | ||
| getattr(table_response.metadata, "location", None), |
Contributor
There was a problem hiding this comment.
i wonder if its necessary to include the "metadata location" here as a fallback; or just always use table_response.metadata_location
| metadata_location: Optional[str] = Field(alias="metadata-location", default=None) | ||
| metadata: TableMetadata | ||
| config: Properties = Field(default_factory=dict) | ||
| storage_credentials: Optional[List[StorageCredential]] = Field(alias="storage-credentials", default=None) |
Contributor
There was a problem hiding this comment.
nit: might be easier to just just List here
Suggested change
| storage_credentials: Optional[List[StorageCredential]] = Field(alias="storage-credentials", default=None) | |
| storage_credentials: List[StorageCredential] = Field( | |
| default_factory=list, | |
| alias="storage-credentials" | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2594
Rationale for this change
According to the Iceberg specification, clients must first check whether the respective credentials exist in the
storage-credentialsfield before checking theconfigfor credentials and choose the most specific prefix if several credentials of the same type are available.Are these changes tested?
Yes, I added two tests:
test_storage_credentials_over_configandtest_config_when_no_storage_credentialsto verify the behavior.Are there any user-facing changes?
No