Closed
Conversation
This was referenced Oct 7, 2025
kevinjqliu
pushed a commit
that referenced
this pull request
Oct 7, 2025
) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Closes #2590 I seem to be faster than the dependabot : ). Pin pydantic version to `<2.12.0` to avoid the recent regression: pydantic/pydantic#12347. I made this an upper bound because it is unclear about the fix plan in pydantic community. Once their fix is out, we could release the upper bound and exclude affected versions only ## Are these changes tested? No dependency version update. Tested the new version in #2589 and confirmed the regression ## Are there any user-facing changes? No cc: @Fokko @kevinjqliu <!-- In the case of user-facing changes, please add the changelog label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Try to upgrade pydantic to
2.12.0, it may break things due to the upstream regression: pydantic/pydantic#12347Will file the actual PR if this is case
Are these changes tested?
Are there any user-facing changes?