Make Reference JSON serializable#2564
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Oct 5, 2025
Merged
Conversation
Contributor
Author
|
@kevinjqliu Easy one, this one unblocks the expressions that use |
kevinjqliu
approved these changes
Oct 5, 2025
Comment on lines
-224
to
-226
| def __eq__(self, other: Any) -> bool: | ||
| """Return the equality of two instances of the Reference class.""" | ||
| return self.name == other.name if isinstance(other, Reference) else False |
Contributor
There was a problem hiding this comment.
pydantic should fall back to the RootModel's __eq__ which checks the root fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?