use PyArrowFileIO as default for abfs and wasb schemes#2395
Merged
kevinjqliu merged 2 commits intoapache:mainfrom Aug 28, 2025
Merged
use PyArrowFileIO as default for abfs and wasb schemes#2395kevinjqliu merged 2 commits intoapache:mainfrom
kevinjqliu merged 2 commits intoapache:mainfrom
Conversation
NikitaMatskevich
approved these changes
Aug 28, 2025
Contributor
NikitaMatskevich
left a comment
There was a problem hiding this comment.
Very good catch!
kevinjqliu
reviewed
Aug 28, 2025
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
thanks for the PR @alessandro-nori
i would prefer to swap the order and default to fsspec for now. Users can still optionally pick pyarrow. the pyarrow AzureFileSystem implementation is only available for versions >= 20.0.0, which is quite recent
iceberg-python/pyiceberg/io/pyarrow.py
Lines 518 to 523 in 3eecdad
we can revisit this in the future when we bump up our pyarrow version
WDYT?
Contributor
Author
|
Thanks for the review @kevinjqliu ! |
Contributor
|
Thanks @alessandro-nori and thank you for the review @NikitaMatskevich |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Now that pyarrow FileIO supports ADLS, we can update the SCHEMA_TO_FILE_IO mapping for
abfsandwasbto use ARROW_FILE_IO, similar to how it’s handled for s3We’re keeping FsspecFileIO as the preferred default, since the PyArrowFileIO implementation is only available in pyarrow >= 20.0.0
Are these changes tested?
Are there any user-facing changes?
Add mapping SCHEMA_TO_FILE_IO for
wasbandabfstoFsspecFileIOandPyArrowFileIO