Merged
Conversation
kevinjqliu
commented
Aug 22, 2025
|
|
||
| ```sh | ||
| svn checkout https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-${PYICEBERG_VERSION}/ ${PYICEBERG_VERIFICATION_DIR} | ||
| svn checkout https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-$PYICEBERG_VERSION/ ${PYICEBERG_VERIFICATION_DIR} |
Contributor
Author
There was a problem hiding this comment.
previously ${PYICEBERG_VERSION} would expand to $\{PYICEBERG_VERSION\}/ in iterm and mess up the url
Contributor
Author
There was a problem hiding this comment.
same, but no more!
Fokko
reviewed
Aug 25, 2025
Fokko
approved these changes
Aug 28, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up @kevinjqliu 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Minor quality of life changes to release docs
Apache PyIceberg->PyIceberg. "Apache PyIceberg" sounds like a top-level, standalone project. I prefer we use use just "PyIceberg"Are these changes tested?
Are there any user-facing changes?