Conversation
acd1b28 to
ee8f952
Compare
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this
|
looks like the linter is breaking CI, can you run |
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
Could you do make lint again?
markdownlint.............................................................Failed
- hook id: markdownlint
- files were modified by this hook
And put the PR in "review" instead of draft
Running this locally already passes everything, I'll try rebasing from ❯ make lint
poetry run pre-commit run --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
debug statements (python)................................................Passed
check yaml...............................................................Passed
check python ast.........................................................Passed
ruff (legacy alias)......................................................Passed
ruff format..............................................................Passed
mypy.....................................................................Passed
markdownlint.............................................................Passed
pydocstyle...............................................................Passed
flynt....................................................................Passed
codespell................................................................PassedEdit: after rebasing, looks like the markdown errors were caused by another PR's change – I've fixed the linting errors in this PR. |
5918924 to
d0c11c8
Compare
d0c11c8 to
376ca2b
Compare
Fokko
left a comment
There was a problem hiding this comment.
Looks good, thanks for working on this @jtuglu1
Should we also add a small section on the expression page?
Sure. It doesn't appear that documentation for this belongs in |
3702b54 to
8223936
Compare
Rationale for this change
Fixes #792
Are these changes tested?
Are there any user-facing changes?
Add
BETWEENoperator