Merged
Conversation
Fokko
approved these changes
Aug 18, 2025
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Makes sense, thanks for fixing this @kevinjqliu
@djouallah looking forward seeing your findings 👍
|
@Fokko yes it works :)
|
Contributor
|
@djouallah Awesome, thanks for letting us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rationale for this change
Closes #2328
Pass
tokenstring ascredentialinAzureBlobFileSystem, https://fsspec.github.io/adlfs/api/This is a known workaround as described by Azure/azure-sdk-for-python#9075 (comment)
I've also made a feature request for java implementation apache/iceberg#13818
Note,
pyarrow.fs.AzureFileSystemdoes not currently expose credential as a parameterAre these changes tested?
Yes, manually since azurite does not integrate with entra.
heres a repro script
Are there any user-facing changes?