Merged
Conversation
add tests add line breaks for consistency add line breaks for consistency
gtrettenero
force-pushed
the
add_snapshot_summary_property
branch
from
1a21a73 to
e552828
Compare
bryanck
approved these changes
Jul 11, 2025
kevinjqliu
approved these changes
Jul 15, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Heres the relevant code in the java implementation https://github.com/apache/iceberg/blob/07afd84080b323c37cb11cbc657fb719891ed91c/core/src/main/java/org/apache/iceberg/SnapshotSummary.java#L203
| @@ -306,6 +307,8 @@ def build(self) -> Dict[str, str]: | |||
| changed_partitions_size = len(self.partition_metrics) | |||
| set_when_positive(properties, changed_partitions_size, CHANGED_PARTITION_COUNT_PROP) | |||
| if changed_partitions_size <= self.max_changed_partitions_for_summaries: | |||
Contributor
There was a problem hiding this comment.
i want to point out that java also gate on the trustPartitionMetrics variable
Contributor
|
Thanks for the PR @gtrettenero and @bryanck for the review :) |
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Adding the snapshot property to keep parity with
[Java](https://github.com/apache/iceberg/commits/main/core/src/main/java/org/apache/iceberg/SnapshotSummary.java)
# Are these changes tested?
Yes I modified two of the existing tests to add this property and added
an additional two for cases where the table is unchanged or
unpartitioned.
# Are there any user-facing changes?
Yes, this will add a property to the Snapshot Summaries when partitions
are changed.
<!-- In the case of user-facing changes, please add the changelog label.
-->
---------
Co-authored-by: Giorgio Trettenero <gtret@netflix.com>
Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Adding the snapshot property to keep parity with Java
Are these changes tested?
Yes I modified two of the existing tests to add this property and added an additional two for cases where the table is unchanged or unpartitioned.
Are there any user-facing changes?
Yes, this will add a property to the Snapshot Summaries when partitions are changed.