chore: specify test paths to integrate with vscode testing extension#2194
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Jul 10, 2025
Merged
Conversation
Add `testpaths` option to enjoy the Test Explorer UI extension in development. Without this option, though the Python Test Adpater Log will run `pytest --collect-only` to discovery tests, it will potential occur error when parsing the test files (e.g. Import Error).
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the testpaths option to the pytest configuration to scope test discovery to the tests directory, preventing import errors in the Test Explorer UI.
- Specify
testpaths = ["tests"]under[tool.pytest.ini_options]inpyproject.toml
dingo4dev
changed the title
kevinjqliu
approved these changes
Jul 10, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Make sense, LGTM
this is the pytest docs for testpaths
https://docs.pytest.org/en/7.1.x/reference/reference.html#confval-testpaths
Contributor
Author
|
@kevinjqliu Thanks for your review! 🚀 |
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
…pache#2194) # Rationale for this change Add `testpaths` option to enjoy the Test Explorer UI extension in development. Without this option, though the Python Test Adpater Log will run `pytest --collect-only` to discovery tests, it will potential occur error when parsing the test files (e.g. Import Error). --- ## Results: | Before adding `testpaths` | After adding `testpaths` | |------------------------------|---------------------------| | | | After adding `testpaths`: # Are these changes tested? Yes, Tested on Codespace and local VScode # Are there any user-facing changes? No, this change not affect any iceberg code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add
testpathsoption to enjoy the Test Explorer UI extension in development. Without this option, though the Python Test Adpater Log will runpytest --collect-onlyto discovery tests, it will potential occur error when parsing the test files (e.g. Import Error).Results:
testpathstestpathsAfter adding
testpaths:Are these changes tested?
Yes, Tested on Codespace and local VScode
Are there any user-facing changes?
No, this change not affect any iceberg code.