Open
Conversation
yingjianwu98
force-pushed
the
yingjianw/roaringBitMap
branch
2 times, most recently
from
9760f90 to
42ccaef
Compare
supporting roaringBitMap supporting roaringBitMap rename
yingjianwu98
force-pushed
the
yingjianw/roaringBitMap
branch
from
42ccaef to
94a7c6a
Compare
kevinjqliu
reviewed
Jan 16, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
I just saw this PR. Thank you @yingjianwu98
Do you know rebasing off main? Let's try to get this in 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is the first change to support deletion vector write in pyiceberg, where we build an abstraction on top of the Bitmap for various operations.
Jave implementation for reference
Are these changes tested?
Yes, I have added all tests from Java except one that validates the ByteOrder as python bytes does not support Order like Java ByteBuffer
Are there any user-facing changes?
No, this is a new class that is currently not used in any existing code path.