Run test_create_table_transaction for Rest V1 tables#2137
Merged
Conversation
kevinjqliu
approved these changes
Jun 23, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
Theres another one of these in
iceberg-python/tests/integration/test_writes/test_writes.py
Lines 945 to 948 in e937f6a
I did a search for pytest.skip https://grep.app/search?f.repo.pattern=iceberg-python&q=pytest.skip
kevinjqliu
reviewed
Jun 23, 2025
| @@ -279,7 +279,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
good catch, i think we can also remove L276-L278
Contributor
Author
There was a problem hiding this comment.
Unfortunally not, the OR REPLACE syntax requires a SQL extension I believe, so I'll leave that one for now.
Contributor
Author
|
Thanks @kevinjqliu for the review 🙌 |
This was referenced Jun 23, 2025
Fokko
pushed a commit
that referenced
this pull request
Jun 24, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Follow up to #2137
Remove all mentions of `CREATE OR REPLACE` issue,
apache/iceberg#8756
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
Fokko
pushed a commit
to apache/iceberg-go
that referenced
this pull request
Jun 24, 2025
Remove all mentions of `CREATE OR REPLACE` issue, apache/iceberg#8756 Similar to apache/iceberg-python#2137 and apache/iceberg-python#2140
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Moar test coverage :)
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Follow up to apache#2137
Remove all mentions of `CREATE OR REPLACE` issue,
apache/iceberg#8756
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Moar test coverage :)
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Follow up to apache#2137
Remove all mentions of `CREATE OR REPLACE` issue,
apache/iceberg#8756
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Moar test coverage :)
Are these changes tested?
Are there any user-facing changes?