feat: support pagination in list_* methods in rest catalog#2089
feat: support pagination in list_* methods in rest catalog#2089jayceslesar wants to merge 5 commits intoapache:mainfrom
list_* methods in rest catalog#2089Conversation
|
Current CI failures look like they should be fixed in a different commit |
kevinjqliu
left a comment
There was a problem hiding this comment.
i think we should support pageSize as well https://github.com/apache/iceberg/blob/17f9a9fd28bbcb37745f13ebfcd57cd5a96e0a5d/open-api/rest-catalog-open-api.yaml#L244-L258
|
@kevinjqliu wdyt about a |
|
lmk what you think this needs, imo if a user really needs to be able to make single requests they can write the thin layer to do that but if we want to provide the most basic level of call against the list API's I am happy to implement. |
|
@kevinjqliu im gonna take another stab at this to see if we can accomplish with less changes |
|
closing in favor of #2158 |
Closes #2084
Rationale for this change
Support pagination!
I looked at the rust iceberg implementation and noticed there is no laziness there either so seems fine for the non-lazy list methods to just exhaust into a list.
Also needed to move all requests behind a
self._request_with_retriesmethod that now handles all previous retry logicAre these changes tested?
Added tests
Are there any user-facing changes?
Sort of. Existing compatability is not broken but there are new methods to lazily use the
list_*methods.