maint: let requests handle params formatting#2086
Merged
Fokko merged 7 commits intoapache:mainfrom Jun 14, 2025
Merged
Conversation
jayceslesar
commented
Jun 12, 2025
jayceslesar
commented
Jun 12, 2025
Fokko
reviewed
Jun 13, 2025
jayceslesar
changed the title
Fokko
reviewed
Jun 13, 2025
pyiceberg/catalog/rest/__init__.py
Outdated
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| import re |
Fokko
reviewed
Jun 13, 2025
pyiceberg/catalog/rest/__init__.py
Outdated
Comment on lines
86
to
88
| CAMEL_TO_SNAKE_CASE_PATTERN = re.compile(r"(?<!^)(?=[A-Z])") | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| CAMEL_TO_SNAKE_CASE_PATTERN = re.compile(r"(?<!^)(?=[A-Z])") |
Fokko
approved these changes
Jun 13, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Super close, I think we can clean up the regex as well 👍
Contributor
|
Thanks @jayceslesar 🙌 |
3 tasks
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let
requestshandle dealing with params instead of using.formaton a templated string.