fix: glue drop_namespace to check non-iceberg tables#2083
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Jun 12, 2025
Merged
fix: glue drop_namespace to check non-iceberg tables#2083kevinjqliu merged 1 commit intoapache:mainfrom
kevinjqliu merged 1 commit intoapache:mainfrom
Conversation
geruh
changed the title
geruh
changed the title
kevinjqliu
approved these changes
Jun 12, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM this prevents us from dropping a namespace when there are other non-iceberg tables still present
| except NoSuchNamespaceError as e: | ||
| table_list_response = self.glue.get_tables(DatabaseName=database_name) | ||
| table_list = table_list_response["TableList"] | ||
| except self.glue.exceptions.EntityNotFoundException as e: |
Contributor
There was a problem hiding this comment.
self.glue.exceptions.EntityNotFoundException mirrors the list_tables implementation
iceberg-python/pyiceberg/catalog/glue.py
Lines 725 to 726 in 26829ff
kevinjqliu
reviewed
Jun 12, 2025
| try: | ||
| table_list = self.list_tables(namespace=database_name) | ||
| except NoSuchNamespaceError as e: | ||
| table_list_response = self.glue.get_tables(DatabaseName=database_name) |
Contributor
There was a problem hiding this comment.
amitgilad3
pushed a commit
to amitgilad3/iceberg-python
that referenced
this pull request
Jul 7, 2025
# Rationale for this change This PR is adding a check for all tables in the GlueCatalog instead of just iceberg tables. GlueCatalog allows users to store other table formats under the same database. Using the catalog's `list_tables()` call filters out non-Iceberg table types, which avoids the proper Iceberg `NamespaceNotEmptyError` and instead returns a generic Glue SDK error. This change aligns with the behavior in the java implementation: - https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java#L538-L571 # Are these changes tested? Tested locally with Glue Catalog # Are there any user-facing changes? Yes new exception message when a `drop_namespace()` call is made against a database with non-iceberg tables.
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
# Rationale for this change This PR is adding a check for all tables in the GlueCatalog instead of just iceberg tables. GlueCatalog allows users to store other table formats under the same database. Using the catalog's `list_tables()` call filters out non-Iceberg table types, which avoids the proper Iceberg `NamespaceNotEmptyError` and instead returns a generic Glue SDK error. This change aligns with the behavior in the java implementation: - https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java#L538-L571 # Are these changes tested? Tested locally with Glue Catalog # Are there any user-facing changes? Yes new exception message when a `drop_namespace()` call is made against a database with non-iceberg tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR is adding a check for all tables in the GlueCatalog instead of just iceberg tables.
GlueCatalog allows users to store other table formats under the same database. Using the catalog's
list_tables()call filters out non-Iceberg table types, which avoids the proper IcebergNamespaceNotEmptyErrorand instead returns a generic Glue SDK error.This change aligns with the behavior in the java implementation:
Are these changes tested?
Tested locally with Glue Catalog
Are there any user-facing changes?
Yes new exception message when a
drop_namespace()call is made against a database with non-iceberg tables.