[test] Run partition transform tests for all transforms#1592
Closed
kevinjqliu wants to merge 2 commits intoapache:mainfrom
Closed
[test] Run partition transform tests for all transforms#1592kevinjqliu wants to merge 2 commits intoapache:mainfrom
kevinjqliu wants to merge 2 commits intoapache:mainfrom
Conversation
245ae20 to
2c3e97f
Compare
Contributor
Author
|
CI failed https://github.com/apache/iceberg-python/actions/runs/13464196511/job/37626276454?pr=1592 cc @Fokko do you think this is a bug on the rust side? |
Contributor
Author
Contributor
|
Yes, looks like it. Let me submit a patch, thanks! |
Contributor
Author
|
nightly build doing its job :) |
kevinjqliu
pushed a commit
to apache/iceberg-rust
that referenced
this pull request
Feb 21, 2025
We found an issue in apache/iceberg-python#1592
2c3e97f to
be11aca
Compare
Contributor
Author
|
all good here, thanks for the quick fix @Fokko |
Fokko
approved these changes
Mar 4, 2025
Contributor
Fokko
left a comment
There was a problem hiding this comment.
LGTM, can you fix the conflicts @kevinjqliu? 🚀
Contributor
Author
|
@Fokko cant merge this yet, we have to wait until pyiceberg_core 0.5.0 release. This PR is override the dependency to use the nightly pyiceberg_core |
Contributor
Author
|
closing in favor of #1833 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1591
Blocked on iceberg-rust/#920 and the next release of pyiceberg_core (0.5.0)