Conversation
…ontaining a dot Writes a COW table partitioned on the nested field fare.currency with hive-style partitioning and asserts the partitioned record index resolves every key in the fare.currency=USD partition, after the initial insert and after an upsert. Reverting the escapeFileName change from apache#19751 makes this fail on the first write, so the test guards that fix rather than passing vacuously.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19964 +/- ##
=========================================
Coverage 80.31% 80.32%
+ Complexity 34751 34750 -1
=========================================
Files 2546 2546
Lines 142522 142522
Branches 17304 17304
=========================================
+ Hits 114465 114475 +10
+ Misses 20162 20147 -15
- Partials 7895 7900 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
issue: #19750
#19751 fixed the escaping but only added unit tests on
PartitionPathEncodeUtils.escapeFileName. Nothing exercises partitioned RLI end to end on a dotted partition column, so a regression in the file-id or log-file-name path would not be caught.Summary and Changelog
Adds
TestRecordLevelIndex#testPartitionedRecordLevelIndexWithDotInHiveStylePartitionColumn: writes a COW table partitioned on the nested fieldfare.currencywith hive-style partitioning, then asserts the partitioned record index resolves every key in thefare.currency=USDpartition, both after the initial insert and after an upsert.Verified non-vacuous: with the
escapeFileNamechange from #19751 reverted the test fails on the first write (the unescaped dot makes the record-index log file name unparseable, sorecord_indexis not recognized among the inflight metadata partitions); with it in place the test passes.Coverage is deliberately limited to the dotted column name, matching the scope of the fix. Dotted partition values, nested hive-style paths and non-hive-style dotted paths remain covered only by the unit assertions in
TestPartitionPathEncodeUtils.Impact
None. Test-only.
Risk Level
none
Documentation Update
none
Contributor's checklist