Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR apache#632
…rification errors to be ignored. (cherry picked from commit 3a71706)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
test/modules/ssl/test_002_verify_client.pycovering the secondSSLVerifyClientargument proposed in #632, together with that PR's functional commit so the new cases have something to run against. Only the third commit of #632 is carried here: its first two reverse each other exactly, and dropping both leaves an identical tree.Six client credentials, each built to raise one specific verification error: unknown issuer (leaf only, and leaf plus its root), self-signed, expired, not-yet-valid, and serverAuth-only EKU. The cases cover plain
requirerejecting all of them,optional_no_cawaiving exactly its documented set, eachaccepted-errorstoken waiving its own error and no other, comma-separated lists, and both configuration errors being rejected at startup.optional_no_cais unchanged by #632: the regression reported in #632 (comment) does not reproduce on trunk.One thing the coverage turned up: no single token reproduces
optional_no_ca. A certificate from an unknown CA raises several errors as the chain is walked, sorequire untrusted-certrejects it whilerequire self-signed,untrusted-cert,invalid-signatureaccepts it. Whether the error is 20 (unable to get local issuer certificate) or 21 (unable to verify the first certificate) also depends on whether the client sends its issuer alongside the leaf, and those two codes sit under different tokens. Worth either documenting the combination or givinguntrusted-certthe whole unknown-issuer set.🤖 Generated with Claude Code