Skip to content

CGI bucket: log an error for read failures #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notroj wants to merge 1 commit into from
+4 −2
Closed

CGI bucket: log an error for read failures #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions modules/generators/cgi_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,20 +312,22 @@ static apr_status_t cgi_read_stdout(apr_bucket *a, apr_file_t *out,
{
char *buf;
apr_status_t rv;
struct cgi_bucket_data *data = a->data;

*str = NULL;
*len = APR_BUCKET_BUFF_SIZE;
buf = apr_bucket_alloc(*len, a->list); /* XXX: check for failure? */

rv = apr_file_read(out, buf, len);

if (rv != APR_SUCCESS && rv != APR_EOF) {
ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, data->r, APLOGNO(10599)
"failed reading stdout from script %s",
data->r->filename);
apr_bucket_free(buf);
return rv;
}

if (*len > 0) {
struct cgi_bucket_data *data = a->data;
apr_bucket_heap *h;

/* Change the current bucket to refer to what we read */
Expand Down