fix message length validation in ajp_msg_check_header#611
Open
rootvector2 wants to merge 1 commit intoapache:trunkfrom
Open
fix message length validation in ajp_msg_check_header#611rootvector2 wants to merge 1 commit intoapache:trunkfrom
rootvector2 wants to merge 1 commit intoapache:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ajp_msg_check_header() validates msglen against msg->max_size,
but ajp_ilink_receive() reads the body starting at buf + AJP_HEADER_LEN.
This means msglen values up to msg->max_size can pass validation while
writing past the end of the allocated buffer.
Restrict msglen to msg->max_size - AJP_HEADER_LEN to ensure the body
fits within msg->buf.