Added application/x-www-form-urlencoded support to the Jakarta REST client backed by a collection of NameValuePair#844
Open
arturobernalg wants to merge 1 commit into
Conversation
Member
|
@arturobernalg Great! But we also need a content consumer, don't we? |
arturobernalg
force-pushed
the
rest-form-urlencoded
branch
3 times, most recently
from
8edd9f6 to
9cc7a7e
Compare
ok2c
reviewed
Jul 5, 2026
arturobernalg
force-pushed
the
rest-form-urlencoded
branch
from
9cc7a7e to
b1be68b
Compare
ok2c
reviewed
Jul 6, 2026
| } | ||
| final List<ContentType> consumesContentTypes = rm.getConsumesContentTypes(); | ||
| if (consumesContentTypes != null && !consumesContentTypes.isEmpty()) { | ||
| // @Produces declares the media type(s) the client accepts back (Accept header). |
Member
There was a problem hiding this comment.
@arturobernalg Indeed. It looks like I made a mistake here. @Produces declares what the endpoint produces and what client can choose to accept. Good catch.
ok2c
approved these changes
Jul 6, 2026
ok2c
reviewed
Jul 7, 2026
| .thenApply(result -> { | ||
| throwIfError(result); | ||
| final Header header = result.getHead().getFirstHeader(HttpHeaders.CONTENT_TYPE); | ||
| final ContentType contentType = header != null ? ContentType.parse(header.getValue()) : null; |
Member
There was a problem hiding this comment.
@arturobernalg One small thing. Let's make ContentType parsing more efficient:
final ContentType contentType = header != null ? MessageSupport.parserHeaderValue(header, ContentType::parse) : null;
arturobernalg
force-pushed
the
rest-form-urlencoded
branch
from
b1be68b to
672a54a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.