Issue #3051 : Harden Filter Rows date constant parsing - #8185
Merged
Conversation
Parse date/timestamp condition constants with the stored mask first, then fall back to Hop's compatible date format so legacy pipelines still evaluate. Keep the condition editor open when conversion fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter Rows (and other
Conditionusers) still fail when a Date constant was saved with Hop's canonical text (yyyy/MM/dd HH:mm:ss.SSS) and a different user mask such asyyyy-MM-dd. Evaluation parsed the stored text with the user mask and threw; reopening the constant in the editor hit the same conversion and could not be edited.This hardens
Condition.CValue.createValueData()to try the stored mask first, then the compatible Hop date format, then the type default. Date/Timestamp only; numeric constants are unchanged. Empty date masks are persisted so later loads do not depend onHOP_DEFAULT_DATE_FORMAT. The condition editor now keeps the stored text when conversion fails (legacy XML or a variable), and Join Rows passes variables into the same editor.fixes #3051
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.