Skip to content

HIVE-28117: Fix misleading YYYY date pattern in add_months() documentation #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prabal864 wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −8
Open

HIVE-28117: Fix misleading YYYY date pattern in add_months() documentation #6718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a92e1d0
HIVE-28117: Fix misleading YYYY date pattern in add_months() document…
Prabal864 Aug 22, 2026
d958917
HIVE-28117: Update udf_add_months.q.out for yyyy-MM-dd doc format change
Prabal864 Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
+ "Returns the date that is num_months after start_date.",
extended = "start_date is a string or timestamp indicating a valid date. "
+ "num_months is a number. output_date_format is an optional String which specifies the format for output.\n"
+ "The default output format is 'YYYY-MM-dd'.\n"
+ "The default output format is 'yyyy-MM-dd'.\n"
+ "Example:\n > SELECT _FUNC_('2009-08-31', 1) FROM src LIMIT 1;\n" + " '2009-09-30'."
+ "\n > SELECT _FUNC_('2017-12-31 14:15:16', 2, 'YYYY-MM-dd HH:mm:ss') LIMIT 1;\n"
+ "\n > SELECT _FUNC_('2017-12-31 14:15:16', 2, 'yyyy-MM-dd HH:mm:ss') LIMIT 1;\n"
+ "'2018-02-28 14:15:16'.\n")
@NDV(maxNdv = 250) // 250 seems to be reasonable upper limit for this
public class GenericUDFAddMonths extends GenericUDF {
Expand Down
8 changes: 4 additions & 4 deletions ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
*/
public class TestGenericUDFAddMonths {

private final Text fmtTextWithTime = new Text("YYYY-MM-dd HH:mm:ss");
private final Text fmtTextWithTimeAndms = new Text("YYYY-MM-dd HH:mm:ss.SSS");
private final Text fmtTextWithoutTime = new Text("YYYY-MM-dd");
private final Text fmtTextInvalid = new Text("YYYY-abcdz");
private final Text fmtTextWithTime = new Text("yyyy-MM-dd HH:mm:ss");
private final Text fmtTextWithTimeAndms = new Text("yyyy-MM-dd HH:mm:ss.SSS");
private final Text fmtTextWithoutTime = new Text("yyyy-MM-dd");
private final Text fmtTextInvalid = new Text("yyyy-abcdz");

@Test
public void testAddMonthsInt() throws HiveException {
Expand Down
4 changes: 2 additions & 2 deletions ql/src/test/results/clientpositive/llap/udf_add_months.q.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ POSTHOOK: query: DESCRIBE FUNCTION EXTENDED add_months
POSTHOOK: type: DESCFUNCTION
add_months(start_date, num_months, output_date_format) - Returns the date that is num_months after start_date.
start_date is a string or timestamp indicating a valid date. num_months is a number. output_date_format is an optional String which specifies the format for output.
The default output format is 'YYYY-MM-dd'.
The default output format is 'yyyy-MM-dd'.
Example:
> SELECT add_months('2009-08-31', 1) FROM src LIMIT 1;
'2009-09-30'.
> SELECT add_months('2017-12-31 14:15:16', 2, 'YYYY-MM-dd HH:mm:ss') LIMIT 1;
> SELECT add_months('2017-12-31 14:15:16', 2, 'yyyy-MM-dd HH:mm:ss') LIMIT 1;
'2018-02-28 14:15:16'.

Function class:org.apache.hadoop.hive.ql.udf.generic.GenericUDFAddMonths
Expand Down