[WIP]HIVE-26441: Expand GenericJdbcDatabaseAccessor unit test coverage#6587
Draft
hemanthumashankar0511 wants to merge 2 commits into
Draft
[WIP]HIVE-26441: Expand GenericJdbcDatabaseAccessor unit test coverage#6587hemanthumashankar0511 wants to merge 2 commits into
hemanthumashankar0511 wants to merge 2 commits into
Conversation
…tDatabaseAccessorByDatabaseType
hemanthumashankar0511
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added H2 unit tests in TestGenericJdbcDatabaseAccessor for iterator partitions, bounds, writer paths, and a minimal test_writer table in test_script.sql.
Why are the changes needed?
To improve DatabaseAccessor test coverage for GenericJdbcDatabaseAccessor as part of HIVE-26441.
Does this PR introduce any user-facing change?
No
How was this patch tested?
mvn test -pl jdbc-handler -Dtest=TestGenericJdbcDatabaseAccessor