[WIP] HIVE-29572: ACID Compaction: Cleaner should check the state of the compaction txn before start cleaning#6498
Open
kuczoram wants to merge 1 commit into
Open
[WIP] HIVE-29572: ACID Compaction: Cleaner should check the state of the compaction txn before start cleaning#6498kuczoram wants to merge 1 commit into
kuczoram wants to merge 1 commit into
Conversation
…mpaction txn before start cleaning
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is not finalised yet, please do not merge it yet!!! Just want to see the test results.
There will be a another fix for the cleaner and once that is done, the SQL changes in the ReadyToCleanHandler should be removed and also the TestCleanerWithMinHistoryWriteId.cleanupAfterMajorCompactionWithQueryWaitingToLockTheSnapshot test has to be enabled again. Also if the check against the open txns in ReadyToCleanHandler, the compaction is not needed to be registered in the MIN_HISTORY_WRITE_ID table.