HBASE-29349 Migrate OpenTelemetry semconv from 1.29.0-alpha to 1.42.0#8479
Open
mnpoonia wants to merge 1 commit into
Open
HBASE-29349 Migrate OpenTelemetry semconv from 1.29.0-alpha to 1.42.0#8479mnpoonia wants to merge 1 commit into
mnpoonia wants to merge 1 commit into
Conversation
Upgrade to stable OpenTelemetry semantic conventions with zero breaking changes using a dual-attribute migration strategy. Changes: - pom.xml: Update opentelemetry-semconv version 1.29.0-alpha -> 1.42.0 - HBaseSemanticAttributes.java: Add 10 new stable attributes with 14 deprecated aliases for backward compatibility - TableMapReduceUtil.java: Update semconv class references for MapReduce dependency checking New Stable Attributes (10): - DB_SYSTEM_NAME, DB_SYSTEM_NAME_VALUE (replaces DB_SYSTEM/DB_SYSTEM_VALUE) - DB_NAMESPACE (replaces DB_NAME) - DB_OPERATION_NAME (replaces DB_OPERATION) - NETWORK_PEER_ADDRESS, NETWORK_PEER_PORT (replaces NET_PEER_NAME/NET_PEER_PORT) - RPC_SYSTEM, RPC_METHOD (defined directly, not in JAR) - EXCEPTION_TYPE, EXCEPTION_MESSAGE (from stable ExceptionAttributes) Deprecated Attributes (14): - DB_SYSTEM, DB_SYSTEM_VALUE -> alias to DB_SYSTEM_NAME/DB_SYSTEM_NAME_VALUE - DB_NAME -> alias to DB_NAMESPACE - DB_OPERATION -> alias to DB_OPERATION_NAME - DB_CONNECTION_STRING, DB_USER -> custom attributes (removed from stable) - RPC_SERVICE -> deprecated (merged into rpc.method in spec) - NET_PEER_NAME -> alias to NETWORK_PEER_ADDRESS - NET_PEER_PORT -> alias to NETWORK_PEER_PORT (stable version) All deprecated attributes marked with @deprecated annotation and Javadoc explaining migration path. Will be removed in HBase 5.x. Unchanged (20): - 17 HBase custom attributes (TABLE_KEY, REGION_NAMES_KEY, etc.) - 3 enums (Operation, RpcSystem, ReadType) Architecture: - Single-file change to HBaseSemanticAttributes.java maintains facade - 42 downstream files work without modification - Dual-attribute phase enables gradual migration - MapReduce jobs ship all required semconv classes to workers Testing: - Full multi-module build succeeds - 67 tracing tests pass (connection, region, exception attributes) - No compilation errors in dependent modules
Contributor
Author
|
@NihalJain @ndimiduk This is same as what yoy guys were doing in |
Contributor
Author
|
I was thinking if we can have this in branch-3 and branch-4 and can also have PR in branch-2 and branch-2.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to stable OpenTelemetry semantic conventions with zero breaking changes using a dual-attribute migration strategy.
Changes:
New Stable Attributes (10):
Deprecated Attributes (14):
All deprecated attributes marked with @deprecated annotation and Javadoc explaining migration path. Will be removed in HBase 5.x.
Unchanged (20):
Architecture:
Testing: