Skip to content

HBASE-30283 list_labels shell command should return readable labels (… #8477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuxiaocs7 merged 1 commit into from
Jul 16, 2026
+17 −1
Merged

HBASE-30283 list_labels shell command should return readable labels (… #8477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion hbase-shell/src/main/ruby/shell/commands/list_labels.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,13 @@ def help

def command(regex = '.*')
list = visibility_labels_admin.list_labels(regex)
labels = []
list.each do |label|
formatter.row([org.apache.hadoop.hbase.util.Bytes.toStringBinary(label.toByteArray)])
label_string = org.apache.hadoop.hbase.util.Bytes.toStringBinary(label.toByteArray)
formatter.row([label_string])
labels << label_string
end
labels
end
end
end
Expand Down
12 changes: 12 additions & 0 deletions hbase-shell/src/test/ruby/hbase/visibility_labels_admin_test_cluster.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,5 +86,17 @@ def teardown
assert_not_nil(res['x:a'])
end

define_test "list_labels should return an Array of readable label Strings" do
label = 'TEST_LIST_LABELS'
command(:add_labels, label)
$TEST_CLUSTER.waitLabelAvailable(10000, label)

labels = command(:list_labels, 'TEST_.*')
assert_kind_of(Array, labels)
labels.each { |l| assert_kind_of(String, l) }
assert(labels.include?(label),
"list_labels should include the created label #{label}")
end

end
end