HBASE-30136 Upgrade hbase-server to use junit5 Part15#8292
Open
liuxiaocs7 wants to merge 1 commit into
Open
Conversation
Member
liuxiaocs7
commented
May 30, 2026
- for branch-2.5
- see: HBASE-30136
There was a problem hiding this comment.
Pull request overview
This PR is part of HBASE-30136 (branch-2.5) to continue migrating hbase-server regionserver tests from JUnit4 to JUnit5, replacing rules/categories/assumptions and updating parameterized test patterns to JUnit5 equivalents used in HBase.
Changes:
- Replaced JUnit4 assertions,
@Before/@After/@BeforeClass/@AfterClass, and@Categorywith JUnit5Assertions,@BeforeEach/@AfterEach/@BeforeAll/@AfterAll, and@Tag. - Migrated JUnit4
TestNamerule usage to JUnit5TestInfo-based naming. - Updated parameterized tests to JUnit5 mechanisms (
@TestTemplate+@HBaseParameterizedTestTemplate, and@ParameterizedClass+@MethodSource) where applicable.
Reviewed changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java | JUnit5 assertions/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java | JUnit5 assertions/tags/assumptions; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFlushRegionEntry.java | JUnit5 lifecycle annotations and TestInfo naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFlushLifeCycleTracker.java | JUnit5 lifecycle annotations and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFailedAppendAndSync.java | JUnit5 assertions/lifecycle; update assertion message argument order. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java | JUnit5 assertions/lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionRandomKeying.java | JUnit5 assertions/lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionKeyRotation.java | JUnit5 assertions/lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionDisabled.java | Replace ExpectedException with assertThrows; JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDirectStoreSplitsMerges.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDeleteMobTable.java | JUnit5 assertions/lifecycle/tags; remove Assert usage. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java | JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java | JUnit5 lifecycle; refactor to support stable per-test names (incl. parameterized suffix). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java | JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicyOverflow.java | JUnit5 tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicyHeterogeneousStorage.java | JUnit5 tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicy.java | JUnit5 tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataBlockEncodingTool.java | JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java | JUnit5 lifecycle/tags; assertion message argument order updates. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSplitThread.java | JUnit5 lifecycle/tags; replace manual try/catch fail with assertDoesNotThrow. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactorMemLeak.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionWithShippingCoprocessor.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionWithCoprocessor.java | JUnit5 tags; remove JUnit4 class rule usage. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionWithByteBuff.java | JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionPolicy.java | JUnit5 lifecycle; assertion API migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionLifeCycleTracker.java | JUnit5 lifecycle/tags; replace @Ignore with @Disabled. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionInDeadRegionServer.java | Convert JUnit4 parameterized runner to @HBaseParameterizedTestTemplate + @TestTemplate. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionFileNotFound.java | JUnit5 lifecycle/tags; simplify exception handling around compaction. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveIOException.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveConcurrentClose.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionAfterBulkLoad.java | Convert to @HBaseParameterizedTestTemplate + @TestTemplate; adjust temp dir handling. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java | JUnit5 lifecycle/tags; update assumptions/disabled tests and assertion message order. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellFlatMapMemStore.java | Convert to @ParameterizedClass + @MethodSource; JUnit5 tags and lifecycle alignment. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java | JUnit5 tags; refactor setup/teardown hooks to align with new base class behavior. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClusterId.java | JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClearRegionBlockCache.java | Convert JUnit4 parameterized runner to @HBaseParameterizedTestTemplate + @TestTemplate. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCleanupMetaWAL.java | JUnit5 lifecycle/tags; align teardown to shutdownMiniCluster(). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCleanupCompactedFileOnRegionClose.java | JUnit5 lifecycle/tags; assertion message order update. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCleanupCompactedFileAfterFailover.java | JUnit5 lifecycle/tags; assertion message order update. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCellSkipListSet.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCellFlatSet.java | Convert JUnit4 parameterized runner to @HBaseParameterizedTestTemplate + @TestTemplate. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java | Convert JUnit4 parameterized runner to @HBaseParameterizedTestTemplate + @TestTemplate; adjust naming. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBytesReadServerSideScanMetrics.java | JUnit5 lifecycle/tags; replace TestName with TestInfo; assertions migrated. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java | Convert JUnit4 TemporaryFolder/TestName to JUnit5 @TempDir/TestInfo; update parameter source. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java | Convert to @HBaseParameterizedTestTemplate + @TestTemplate; replace expected-exception style with assertThrows. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBrokenStoreFileCleaner.java | JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBloomFilterFaulty.java | JUnit5 lifecycle/tags; replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksScanned.java | JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java | JUnit5 lifecycle/tags; replace TestName with TestInfo; assertion API migration. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java | JUnit5 lifecycle/tags; replace TestName with TestInfo; assertion message order updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.