Skip to content

HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly#7952

Draft
PDavid wants to merge 3 commits intoapache:masterfrom
PDavid:HBASE-29878-author-ignore-nightly
Draft

HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly#7952
PDavid wants to merge 3 commits intoapache:masterfrom
PDavid:HBASE-29878-author-ignore-nightly

Conversation

@PDavid
Copy link
Contributor

@PDavid PDavid commented Mar 17, 2026

The author check fails in nightly build:

hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx:154:Also, no `@author` tags - that's a rule.
hbase-website/public/book.html:40827:<p>Also, no <code>@author</code> tags - that’s a rule.</p>

https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1420/General_20Nightly_20Build_20Report/

Fix:
Ignore files under hbase-website in author checks.

…k in nightly

The author check fails in nightly build:

```
hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx:154:Also, no `@author` tags - that's a rule.
hbase-website/public/book.html:40827:<p>Also, no <code>@author</code> tags - that’s a rule.</p>
```

Ignore files under hbase-website in author checks.
@PDavid PDavid self-assigned this Mar 17, 2026
@PDavid
Copy link
Contributor Author

PDavid commented Mar 17, 2026

Hmm, it seems that the @author check is still failing in the general check. Does it checks it on master or on the branch? 🤔

@PDavid PDavid requested review from Apache9 and ndimiduk March 17, 2026 11:24
@Apache9
Copy link
Contributor

Apache9 commented Mar 17, 2026

13:hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx:154:Also, no `@author` tags - that's a rule.
14:hbase-website/public/book.html:40827:<p>Also, no <code>@author</code> tags - that’s a rule.</p>

Seems still the same error.

@Apache9
Copy link
Contributor

Apache9 commented Mar 17, 2026

This is the log console output, seems we have already used the new config?

AUTHOR_IGNORE_LIST=hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx,hbase-website/public/book.html

@Apache9
Copy link
Contributor

Apache9 commented Mar 17, 2026

Oh wait a minute, what is the syntax for passing multiple ignore files in?

@Apache9
Copy link
Contributor

Apache9 commented Mar 17, 2026

Strange, it is comma separated... @ndimiduk do you have any ideas on this?

function author_parse_args
{
  declare i

  for i in "$@"; do
    case ${i} in
      --author-ignore-list=*)
        delete_parameter "${i}"
        yetus_comma_to_array AUTHOR_IGNORE_LIST "${i#*=}"
      ;;
    esac
  done
}

@PDavid
Copy link
Contributor Author

PDavid commented Mar 17, 2026

Maybe we need space separator, let's see. 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants