HBASE-29970 SplitSuccess and SplitTime metrics are no longer used at …#7866
Open
liuxiaocs7 wants to merge 1 commit intoapache:masterfrom
Open
HBASE-29970 SplitSuccess and SplitTime metrics are no longer used at …#7866liuxiaocs7 wants to merge 1 commit intoapache:masterfrom
liuxiaocs7 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Hi, @Apache9, WDYT, more details see: HBASE-29970 |
liuxiaocs7
commented
Mar 6, 2026
Comment on lines
-219
to
217
|
|
||
| public void incrSplitSuccess() { | ||
| serverSource.incrSplitSuccess(); | ||
| if (table != null) { | ||
| metricsTable.incrSplitRequest(table); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is the addition
…RegionServer and Table level
There was a problem hiding this comment.
Pull request overview
Removes unused RegionServer- and table-level split metrics (SplitSuccess and SplitTime) as part of HBASE-29970, and updates split-request recording to optionally attribute split requests to the originating table.
Changes:
- Remove
SplitSuccessandSplitTimemetrics from RegionServer and table metrics sources/interfaces. - Update
SplitRequestto record split requests with a table name so table-aggregate split-request counters can be incremented. - Add unit tests covering
splitRequestCountat both RegionServer and table-aggregate levels.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsTableAggregate.java | Adds a test verifying table-aggregate splitRequestCount increments only when a table is provided. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java | Adds a test verifying RegionServer splitRequestCount increments. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java | Passes the parent table name into metrics when recording a split request. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTable.java | Removes table-level split success/time update APIs, keeping split-request only. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java | Removes split success/time APIs and changes split-request API to accept an optional table for table-level attribution. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java | Removes split success and split time metric registration/deregistration and related methods. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSource.java | Removes split success/time methods from the table metrics source interface. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java | Removes split success and split time metric registration and related methods. |
| hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java | Removes split success/time constants and methods, keeping split-request only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Apache9
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…RegionServer and Table level