HBASE-28253: HBCK2 filesystem command to fix version file fails when Master in not up.

[robin7roy]

Removed the check for HBCK support in the filesystem command as it causes issues while trying to run command filesystem -f which doesn't need master to be up. Filesystem checks are all offline and doesn't need the master.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	spotbugs	0m 0s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	0m 47s	master passed
+1 💚	compile	0m 10s	master passed
+1 💚	checkstyle	0m 8s	master passed
+1 💚	spotless	0m 7s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 12s	the patch passed
+1 💚	compile	0m 10s	the patch passed
+1 💚	javac	0m 10s	the patch passed
+1 💚	checkstyle	0m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 5s	patch has no errors when running spotless:check.
+1 💚	javadoc	0m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 44s	hbase-hbck2 in the patch passed.
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		8m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-139/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#139
JIRA Issue	HBASE-28253
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs spotless checkstyle compile
uname	Linux 8ee27dedfbb9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / 4d4c928
Default Java	Oracle Corporation-1.8.0_342-b07
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-139/1/testReport/
Max. process+thread count	1289 (vs. ulimit of 5000)
modules	C: hbase-hbck2 U: hbase-hbck2
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-139/1/console
versions	git=2.30.2 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[anoopsjohn]

Any file system struct specific new stuff that we leverage in HBCK2 check/fix? I dont think so
Looks good +1

[robin7roy]

Yeah no new stuff specific to HBCK2, we are still using the hbck1 codebase for filesystem checks

Any file system struct specific new stuff that we leverage in HBCK2 check/fix? I dont think so Looks good +1

[wchevreuil]

There's already a -s|--skip option in hbck2 for skipping the check (see here). I would rather modify checkHBCKSupport to mention this option in case of master connection failure.

[robin7roy]

There's already a -s|--skip option in hbck2 for skipping the check (see here). I would rather modify checkHBCKSupport to mention this option in case of master connection failure.

Ohh missed this option, will make the needful changes in checkHBCKSupport