Skip to content

Fix main failing due to sklearn bump#1594

Closed
ArnavBalyan wants to merge 1 commit into
apache:mainfrom
ArnavBalyan:arnavb/fix-sklearn
Closed

Fix main failing due to sklearn bump#1594
ArnavBalyan wants to merge 1 commit into
apache:mainfrom
ArnavBalyan:arnavb/fix-sklearn

Conversation

@ArnavBalyan
Copy link
Copy Markdown
Member

Changes

  • Main/CI is failing, sklearn got updated to 1.9.0rc1
  • We are not pinned so we picked up the new release which has breaking changes
  • Pin to 1.8.0 last safe version which keeps main intact

How I tested this

  • CI

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@ArnavBalyan
Copy link
Copy Markdown
Member Author

cc @skrawcz thanks!

@ArnavBalyan ArnavBalyan force-pushed the arnavb/fix-sklearn branch from 8bc21f5 to 294e0fc Compare May 22, 2026 03:06
Copy link
Copy Markdown
Contributor

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think I just fixed this on main.

In general we try to either (a) fix forward, (b) handle multiple versions if possible, (c) if we do pin, specify what and why and when to unpin. (d) we could probably lower pin against major version.

@ArnavBalyan
Copy link
Copy Markdown
Member Author

Sg closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants