perf: use deque for BFS queue in graph traversal#1494
Merged
skrawcz merged 2 commits intoapache:mainfrom Mar 1, 2026
Merged
Conversation
compute_nodes_from_sources() drains a BFS queue via .pop(0) which is O(n) per removal. Switch to collections.deque with .popleft() for O(1) front removal.
giulio-leone
force-pushed
the
fix/graph-bfs-deque
branch
from
4a06503 to
0f4678b
Compare
Contributor
Author
|
Friendly ping — CI is green and this is ready for review. Happy to address any feedback. Thanks! |
Contributor
|
Thanks @giulio-leone, there seems to be a linting issue please run the pre-commit hooks and try again. |
skrawcz
approved these changes
Mar 1, 2026
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
compute_nodes_from_sources()inhamilton/execution/graph_functions.pyuses.pop(0)for BFS queue traversal, which is O(n) per removal.Solution
Switch to
collections.dequewith.popleft()for O(1) front removal.