Use a short SPDX license header for LLM-centered files#1489
Use a short SPDX license header for LLM-centered files#1489Dev-iL wants to merge 1 commit intoapache:mainfrom
Conversation
| # Original work Copyright 2017 Palantir Technologies, Inc. # | ||
| # Original work licensed under the MIT License. # | ||
| # See ThirdPartyNotices.txt in the project root for license information. # | ||
| # All modifications Copyright (c) Open Law Library. All rights reserved. # |
There was a problem hiding this comment.
This file seems like a generic conftest, not sure why it had all of the above.
| # Copyright(c) Open Law Library. All rights reserved. # | ||
| # See ThirdPartyNotices.txt in the project root for additional notices. # |
There was a problem hiding this comment.
Removing this might be incorrect in this case. Is this here because the code was vendored in from pygls?
There was a problem hiding this comment.
yeah I dont' recall. so maybe revert?
There was a problem hiding this comment.
Can this be moved to a NOTICE file if the code in question is licensed under ALv2 too? CC: @potiuk
There was a problem hiding this comment.
Yes. It should be placed in the NOTICE file https://infra.apache.org/licensing-howto.html
scripts/add_license_headers.py
Outdated
scripts/check_license_headers.py
Outdated
| - name: Check for missing Apache 2 license headers | ||
| run: python3 scripts/check_license_headers.py | ||
| working-directory: ${{ github.workspace }} |
There was a problem hiding this comment.
This answers all similar comments:
After the proposed change, license headers are being enforced by pre-commit hooks. This approach has several benefits:
- Contributors can tell there's an issue before getting to ci
- Coverage isn't lost since hooks should run on ci anyway as part of static checks
- No need to maintain license enforcement scripts
- Hooks were more thorough and detected missing licenses that the ci missed
Whereas the main downside is it's somewhat harder to customize if a specific file requires special treatment.
Following the approach from Apache Airflow PRs #62073 and #62145, files intended for LLM/agent consumption (not distributed in releases) now use a minimal SPDX license identifier instead of the full Apache 2.0 header - for LLM token efficiency. See also: https://lists.apache.org/thread/j1tn63r2lf13v3d1tnnqff8fkcl4nx53
3 participants
Following the approach from apache/airflow#62073 and apache/airflow#62145, files intended for LLM/agent consumption (not distributed in releases) now use a minimal SPDX license identifier instead of the full Apache 2.0 header - for LLM token efficiency.
See also:
https://lists.apache.org/thread/j1tn63r2lf13v3d1tnnqff8fkcl4nx53
Changes
.githubfolder asexport-ignore.How I tested this
Notes
Checklist