Skip to content

HADOOP-19977. winutils: GetFileInformationByName collides with Windows SDK 10.0.26100 #8713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GauthamBanasandra merged 1 commit into from
Sep 7, 2026
Merged

HADOOP-19977. winutils: GetFileInformationByName collides with Windows SDK 10.0.26100 #8713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,10 @@ static BOOL ParseCommandLineArguments(
// Check if the given path name is a file or directory
// Only set recursive flag if the given path is a directory
//
dwRtnCode = GetFileInformationByName(*path, FALSE, &fileInfo);
dwRtnCode = GetFileInformationByPathName(*path, FALSE, &fileInfo);
if (dwRtnCode != ERROR_SUCCESS)
{
ReportErrorCode(L"GetFileInformationByName", dwRtnCode);
ReportErrorCode(L"GetFileInformationByPathName", dwRtnCode);
return FALSE;
}

Expand Down
3 changes: 2 additions & 1 deletion hadoop-common-project/hadoop-common/src/main/winutils/hardlink.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ static DWORD HardlinkStat(__in LPCWSTR fileName, __out DWORD *puHardLinkCount)

// Get file information which contains the hard link count
//
dwErrorCode = GetFileInformationByName(longFileName, FALSE, &fileInformation);
dwErrorCode = GetFileInformationByPathName(
longFileName, FALSE, &fileInformation);
if (dwErrorCode != ERROR_SUCCESS)
{
goto HardlinkStatExit;
Expand Down
2 changes: 1 addition & 1 deletion hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ void ReadlinkUsage();
int SystemInfo();
void SystemInfoUsage();

DWORD GetFileInformationByName(__in LPCWSTR pathName, __in BOOL followLink,
DWORD GetFileInformationByPathName(__in LPCWSTR pathName, __in BOOL followLink,
__out LPBY_HANDLE_FILE_INFORMATION lpFileInformation);

DWORD CheckAccessForCurrentUser(
Expand Down
6 changes: 3 additions & 3 deletions hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const ACCESS_MASK WinMasks[WIN_MASKS_TOTAL] =
};

//----------------------------------------------------------------------------
// Function: GetFileInformationByName
// Function: GetFileInformationByPathName
//
// Description:
// To retrieve the by handle file information given the file name
Expand All @@ -85,7 +85,7 @@ const ACCESS_MASK WinMasks[WIN_MASKS_TOTAL] =
// or junction point to get the target file information. Otherwise, the
// information for the symbolic link or junction point is retrieved.
//
DWORD GetFileInformationByName(
DWORD GetFileInformationByPathName(
__in LPCWSTR pathName,
__in BOOL followLink,
__out LPBY_HANDLE_FILE_INFORMATION lpFileInformation)
Expand Down Expand Up @@ -888,7 +888,7 @@ DWORD FindFileOwnerAndPermission(

if (pMask == NULL) goto FindFileOwnerAndPermissionEnd;

dwRtnCode = GetFileInformationByName(pathName,
dwRtnCode = GetFileInformationByPathName(pathName,
followLink, &fileInformation);
if (dwRtnCode != ERROR_SUCCESS)
{
Expand Down
4 changes: 2 additions & 2 deletions hadoop-common-project/hadoop-common/src/main/winutils/ls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,11 +280,11 @@ int Ls(__in int argc, __in_ecount(argc) wchar_t *argv[])
goto LsEnd;
}

dwErrorCode = GetFileInformationByName(
dwErrorCode = GetFileInformationByPathName(
longPathName, optionsMask & CmdLineOptionFollowSymlink, &fileInformation);
if (dwErrorCode != ERROR_SUCCESS)
{
ReportErrorCode(L"GetFileInformationByName", dwErrorCode);
ReportErrorCode(L"GetFileInformationByPathName", dwErrorCode);
goto LsEnd;
}

Expand Down
Loading