HDFS-17934. RBF: Add router web address to router web UI#8540
Open
kokonguyen191 wants to merge 2 commits into
Open
HDFS-17934. RBF: Add router web address to router web UI#8540kokonguyen191 wants to merge 2 commits into
kokonguyen191 wants to merge 2 commits into
Conversation
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Jun 17, 2026
Comment on lines
+395
to
+396
| String host = adminAddress.split(":")[0]; | ||
| return "http://" + host + ":" + webPort; |
Member
There was a problem hiding this comment.
how do u know it is http only, we have DFS_ROUTER_HTTPS_ADDRESS_KEY as well
Contributor
Author
There was a problem hiding this comment.
Fair point, updated with HTTPS
| return JSON.toString(info); | ||
| } | ||
|
|
||
| private static String guessRouterWebAddress(String adminAddress, int webPort) { |
Member
There was a problem hiding this comment.
guess isn't a very nice word here & moreover we can't rely on guesswork either
Contributor
Author
There was a problem hiding this comment.
Updated methods to remove guess naming. If we want fully correct per router web address, router state store has to store those data (which currently it does not). I think for a simple web UI improvement and for most deployments with a consistent config for all routers in a cluster, this is a fair compromise to arrive at
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Pull request overview
Adds a clickable web URL for each Router entry in the RBF Router web UI by deriving the Router web address from the Router’s admin address plus locally configured HTTP/HTTPS port/scheme.
Changes:
- Render Router “Address” as a link when a derived
routerWebAddressis available. - Extend
RBFMetrics#getRouters()JSON output to include arouterWebAddressfield computed from config + router admin address.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/router/federationhealth.html | Conditionally wraps router address in an <a> pointing to routerWebAddress. |
| hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java | Adds derivation of routerWebAddress and injects it into the Routers JSON payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+388
to
+402
| private static String getRouterWebAddress(Configuration conf, String adminAddress) { | ||
| try { | ||
| if (isNullOrEmpty(adminAddress)) { | ||
| return ""; | ||
| } | ||
| String scheme = DFSUtil.getHttpClientScheme(conf); | ||
| int webPort = getRouterWebAddressPort(conf, scheme); | ||
| InetSocketAddress adminSocketAddress = NetUtils.createSocketAddr(adminAddress.trim()); | ||
| return new URI(scheme, null, adminSocketAddress.getHostString(), webPort, null, null, | ||
| null).toString(); | ||
| } catch (Exception e) { | ||
| LOG.error("Cannot get router web address", e); | ||
| return ""; | ||
| } | ||
| } |
| long dateModified = record.getDateModified(); | ||
| long lastHeartbeat = getSecondsSince(dateModified); | ||
| innerInfo.put("lastHeartbeat", lastHeartbeat); | ||
| innerInfo.put("routerWebAddress", getRouterWebAddress(conf, record.getAdminAddress())); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In router web interface, there are clickable URLs for namenodes and datanodes, but none for routers.
This patch uses a hacky method to guess the web URL from configuration and admin address, which works for cluster that runs the same port for all routers, instead of 100% accurately getting it using some other method that requires more intrusive changes to what's stored in the router state store. I think it's a fair compromise for a small improvement that works for most deployments.
How was this patch tested?
Local deployment and test deployment with a few nodes.
No unit tests since it's a minor front end change.